Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix venv path, so we no longer require modification to python path after install #363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix venv path, so we no longer require modification to python path after install #363

wants to merge 2 commits into from

Conversation

AleksKnezevic
Copy link
Contributor

Ticket

#339

Problem description

After installing the tt-torch wheel, you need to set an odd python path for it to work. Fix that.

What's changed

Modify cmake install locations when building a wheel.

Checklist

  • New/Existing tests provide coverage for changes

@github-actions GitHub Actions
Copy link

TestsPassedSkippedFailed ❌️
TT-Torch Tests9 ran0 passed0 skipped9 failed
TestResult
TT-Torch Tests
pytest
test_basic.tests.torch.test_basic❌ failure
test_compare.tests.torch.test_compare❌ failure
test_constant_fold.tests.torch.test_constant_fold❌ failure
test_conv2d.tests.torch.test_conv2d❌ failure
test_interpolation.tests.torch.test_interpolation❌ failure
test_logical.tests.torch.test_logical❌ failure
test_maxpool2d.tests.torch.test_maxpool2d❌ failure
test_reduction.tests.torch.test_reduction❌ failure
test_softmax.tests.torch.test_softmax❌ failure

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2025 •
edited
Loading

❌ 9 Tests Failed:

Tests completed Failed Passed Skipped
9 9 0 0
View the top 3 failed test(s) by shortest run time 
::tests.torch.test_constant_fold
Stack Traces | 0s run time 
ImportError while importing test module '.../tests/torch/test_constant_fold.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../usr/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/torch/test_constant_fold.py:10: in <module>
    from tt_torch.tools.verify import verify_module
tt_torch/tools/verify.py:10: in <module>
    from tt_torch.dynamo.backend import backend
tt_torch/dynamo/backend.py:12: in <module>
    from tt_torch.tools.utils import (
tt_torch/tools/utils.py:16: in <module>
    from tt_mlir import is_runtime_debug_enabled
E   ImportError: cannot import name 'is_runtime_debug_enabled' from 'tt_mlir' (unknown location)
::tests.torch.test_maxpool2d
Stack Traces | 0s run time 
ImportError while importing test module '.../tests/torch/test_maxpool2d.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../usr/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/torch/test_maxpool2d.py:9: in <module>
    from tt_torch.tools.verify import verify_module
tt_torch/tools/verify.py:10: in <module>
    from tt_torch.dynamo.backend import backend
tt_torch/dynamo/backend.py:12: in <module>
    from tt_torch.tools.utils import (
tt_torch/tools/utils.py:16: in <module>
    from tt_mlir import is_runtime_debug_enabled
E   ImportError: cannot import name 'is_runtime_debug_enabled' from 'tt_mlir' (unknown location)
::tests.torch.test_reduction
Stack Traces | 0s run time 
ImportError while importing test module '.../tests/torch/test_reduction.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../usr/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/torch/test_reduction.py:8: in <module>
    from tt_torch.tools.verify import verify_module
tt_torch/tools/verify.py:10: in <module>
    from tt_torch.dynamo.backend import backend
tt_torch/dynamo/backend.py:12: in <module>
    from tt_torch.tools.utils import (
tt_torch/tools/utils.py:16: in <module>
    from tt_mlir import is_runtime_debug_enabled
E   ImportError: cannot import name 'is_runtime_debug_enabled' from 'tt_mlir' (unknown location)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@AleksKnezevic AleksKnezevic force-pushed the aknezevic/fix_venv_path branch from f48c0e7 to 42e306c Compare February 22, 2025 02:58
@github-actions GitHub Actions
Copy link

TestsPassedSkippedFailed ❌️
TT-Torch Tests9 ran0 passed0 skipped9 failed
TestResult
TT-Torch Tests
pytest
test_basic.tests.torch.test_basic❌ failure
test_compare.tests.torch.test_compare❌ failure
test_constant_fold.tests.torch.test_constant_fold❌ failure
test_conv2d.tests.torch.test_conv2d❌ failure
test_interpolation.tests.torch.test_interpolation❌ failure
test_logical.tests.torch.test_logical❌ failure
test_maxpool2d.tests.torch.test_maxpool2d❌ failure
test_reduction.tests.torch.test_reduction❌ failure
test_softmax.tests.torch.test_softmax❌ failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmanzoorTT mmanzoorTT Awaiting requested review from mmanzoorTT

@LPanosTT LPanosTT Awaiting requested review from LPanosTT

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AleksKnezevic @codecov-commenter